Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support different codebook sizes in CUDA kernels #39

Open
dryman opened this issue Sep 17, 2019 · 5 comments
Open

Support different codebook sizes in CUDA kernels #39

dryman opened this issue Sep 17, 2019 · 5 comments

Comments

@dryman
Copy link

dryman commented Sep 17, 2019

Does this package support other dimensions than 128?
We'd like to test it on GloVe, which is 100.

@una-dinosauria
Copy link
Owner

Yep, just add your data reading functions to

function read_dataset(

@dryman
Copy link
Author

dryman commented Sep 17, 2019

Does the following code in cuda matter?

// FIXME hard-coding 256 entries in each codebook, and 128 dimensions
const int H = 256; // size of each codebook
const int D = 128; // dimensionality of each vector

@una-dinosauria
Copy link
Owner

Oh right, sorry. The GPU part is hardcoded.

@una-dinosauria
Copy link
Owner

I checked again, since I definitely ran this code on the GPU for my thesis.

The function veccost that you linked above is not called from the Julia part. veccost2 is

// FIXME hard-coding 256 entries in each codebook
const int H = 256; // size of each codebook

which only hardcodes the number of entries in the codebook (not the dataset dimensionality). I'm changing the name of this issue to reflect that.

@una-dinosauria una-dinosauria changed the title Support different dimensions Support different codebook dimensions in CUDA kernels Sep 23, 2019
@una-dinosauria una-dinosauria changed the title Support different codebook dimensions in CUDA kernels Support different codebook sizes in CUDA kernels Sep 23, 2019
@una-dinosauria
Copy link
Owner

Also opened #41 to keep track of code deletion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants