Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Contributing file with information #226

Merged
merged 3 commits into from Nov 2, 2016
Merged

Added Contributing file with information #226

merged 3 commits into from Nov 2, 2016

Conversation

Bobeta
Copy link
Contributor

@Bobeta Bobeta commented Oct 7, 2016

I happened to miss the contribution section in the Readme while looking through the project. As many others do, I was looking for the CONTRIBUTING.md file in the repository, but couldn't find it. I suggest we add it with this pull request 馃憤


## Procedure 1

1. Create an [issue](https://github.com/una/CSSgram/issues)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say look for an issue first becuase a lot of them are already made

2. Clone the fork onto your system
3. `npm install` dependencies (must have Node installed)
4. Run `gulp` to compile CSS and the test site
5. Make changes and check the test site with your changes (see file structure outline below)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing file structure outline here (also mention to edit the .scss file related to the filter)

@una
Copy link
Owner

una commented Oct 20, 2016

Hey -- have you taken a look at any of these comments yet?

@Bobeta
Copy link
Contributor Author

Bobeta commented Oct 23, 2016

I made the requested changes 馃憤

@una
Copy link
Owner

una commented Oct 27, 2016

There's also slightly different information here: #242 with this being merged, please include that as well

@Bobeta
Copy link
Contributor Author

Bobeta commented Oct 31, 2016

There you go 馃憤 an idea would be to just merge it and update it on the fly as new things come along, instead of me maintaining the docs haha 馃槅

@una una merged commit e5a2ad8 into una:master Nov 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants