Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Serializer Calling Private Method #112

Closed
wants to merge 1 commit into from
Closed

Fix Serializer Calling Private Method #112

wants to merge 1 commit into from

Conversation

bert-mccutchen
Copy link

The Serializer class is attempting to call the private method marshal_dump for components. This happens when it is attempting to collect instance variables due to a failing dump.

I don't have the time to write a better fix, so i've just moved the method into public scope.

def dump(component)
dump!(component)
rescue TypeError => e
failing_ivars = []
component.marshal_dump.each do |ivar_name, ivar_value|
dump!(ivar_value)
rescue TypeError
failing_ivars << ivar_name
end

@bert-mccutchen bert-mccutchen changed the title Moved marshal_dump into public scope. Fix Serializer Calling Private Method Jul 9, 2021
@bert-mccutchen bert-mccutchen deleted the patch-1 branch October 12, 2021 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant