Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timeline: problem with ACL check for item viewing #1800

Open
AlexTr opened this issue Nov 20, 2018 · 0 comments
Open

Timeline: problem with ACL check for item viewing #1800

AlexTr opened this issue Nov 20, 2018 · 0 comments
Assignees
Milestone

Comments

@AlexTr
Copy link
Contributor

AlexTr commented Nov 20, 2018

Related fix which cause the problem - 54c386a

There are still problems before and after above fix:

  • after above fix content items(photos for example) can be viewed on browsing pages, but not in Timeline
  • before the above fix some content items (videos for example) can be viewed in full in timeline and it means that ACL checking isn't working

The possible solution - display different content items differently in the Timeline (like we did it for photos - didn't allow to enlarge the photos if 'view photo' ALC action is disabled), so content item should have the same visibility level as on browsing pages, for example video shouldn't be playable in Timeline if 'view video' ACL action is disabled in ACL.

@AlexTr AlexTr added this to the 10 milestone Nov 20, 2018
@andreyasko andreyasko modified the milestones: 10, Future May 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants