Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logo displaying improvement #3877

Closed
7 tasks done
AlexTr opened this issue Jun 9, 2022 · 0 comments
Closed
7 tasks done

Logo displaying improvement #3877

AlexTr opened this issue Jun 9, 2022 · 0 comments
Assignees
Milestone

Comments

@AlexTr
Copy link
Contributor

AlexTr commented Jun 9, 2022

  • - remove width and height settings for all styler
  • - don't resize logo upon upload nor in desiner nor in sytles
  • - allow svg file upload in styles & designer
  • - store optimal height of logo for each template (for stylers it must be dependant on header height, such as header height minus content margin)
  • - calculate aspect ratio of the original image (upon first view) and store it somewhere
  • - display logo with fixed width and height, where height is stored optimal value for each template and width is calculated according to aspect ratio
  • - for svg it's possible to parse XML to get aspect ration(from viewBox attribute) as well, of it's not defined use some default value such as 1.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants