Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HF Hub dependency conflicts with latest tranformers version. #191

Closed
scottfleming opened this issue Dec 15, 2023 · 3 comments
Closed

HF Hub dependency conflicts with latest tranformers version. #191

scottfleming opened this issue Dec 15, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@scottfleming
Copy link

scottfleming commented Dec 15, 2023

🐛 Bug

COMET has an explicit dependency for both transformers = "^4.17" and huggingface-hub = "^0.16.0" which will only allow versions up to 0.17.0, but the newest version of transformers (v4.36.1) has its own huggingface-hub dependency which is >=0.19.3,<1.0. This creates dependency conflicts for anyone trying to build a package on COMET and the latest transformers package. Can we do one of the following:

  1. Remove the huggingface-hub dependency from COMET and just keep the transformers dependency given that the former is implicit in the latter;
  2. Use the same style of huggingface-hub dependency that transformers uses (namely "huggingface-hub>=0.19.3,<1.0") to mitigate dependency conflicts;
  3. At very least, update the huggingface-hub dependency to be ^0.19.3.
@scottfleming scottfleming added the bug Something isn't working label Dec 15, 2023
dasony added a commit to xl8-ai/COMET that referenced this issue Jan 5, 2024
@ricardorei
Copy link
Collaborator

Hi @scottfleming! I like this suggestions but I rather go for 2. Because if for some reason HF decides to decouple the two packages, COMET will stop working (unable to download models).

ricardorei pushed a commit that referenced this issue Jan 8, 2024
@ricardorei
Copy link
Collaborator

I just released a new version that should solve this dependency issue. Ping me if the error still persists.

PS: I went for option 2

@scottfleming
Copy link
Author

Thanks so much, @ricardorei! I'll test this out and let you know if I run into any problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants