Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot set strain threshold modifier on gear #24

Closed
taralx opened this issue May 10, 2019 · 2 comments · Fixed by #41
Closed

Cannot set strain threshold modifier on gear #24

taralx opened this issue May 10, 2019 · 2 comments · Fixed by #41
Labels
bug

Comments

@taralx
Copy link
Contributor

taralx commented May 10, 2019

Describe the bug
Strain threshold modifier is ignored on gear.

To Reproduce
Steps to reproduce the behavior:

  1. Create custom gear with Modifier: yes, Attribute: Strain Threshold, Modifier Value: 1
  2. Add gear to character

Expected behavior
Strain threshold increased.

Additional context
I suspect it gets clobbered here: https://github.com/SkyJedi/RPG-Web-Character-Creator/blob/32881473fd5f9a83abbd5ff49c134b07ca8647b1/src/components/CustomData/CustomEquipment.js#L64
@taralx
Copy link
Contributor Author

taralx commented May 10, 2019

(Also, it would be nice if I could set multiple modifiers on gear/talents...)

@ShaneK ShaneK added the bug label May 16, 2020
@ShaneK ShaneK mentioned this issue Jul 6, 2020
Merged
@ShaneK ShaneK closed this as completed in #41 Jul 6, 2020
@ShaneK
Copy link
Member

ShaneK commented Jul 6, 2020 •
edited

Hey, you were right! That was absolutely it. Sorry it took so long to get fixed! Should be live in a couple minutes.

Edit: Live now with a hard refresh. Version 0.2.1.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
2 participants
@ShaneK @taralx