Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting the title based on the attribute model #35

Closed
unclead opened this issue Sep 15, 2015 · 1 comment
Closed

Getting the title based on the attribute model #35

unclead opened this issue Sep 15, 2015 · 1 comment

Comments

@unclead
Copy link
Owner

unclead commented Sep 15, 2015

Great solution, but the 'title' question isn't solved.
The '+' sign staying there alone, without title, I can't find the proper solution unless the one below.
Probably we need a new property to turn on/off the title and for BC.
(I think we need a title when 'allowEmptyList' is true...)

    protected function guessColumns()
    {
        if (empty($this->columns) && $this->hasModel()) {
            $this->columns = [
                [
                    'name' => $this->attribute,
                    'type' => MultipleInputColumn::TYPE_TEXT_INPUT,
                    'title' =>$this->model->getAttributeLabel($this->attribute), // recommended line
                ]
            ];
        }
    }

@unclead
Copy link
Owner Author

unclead commented Sep 16, 2015

closed via b483b48

@unclead unclead closed this as completed Sep 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant