Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature to search method/scenario in pages. #1409

Merged
merged 3 commits into from Jan 28, 2023
Merged

Feature to search method/scenario in pages. #1409

merged 3 commits into from Jan 28, 2023

Conversation

suratdas
Copy link
Contributor

@suratdas suratdas commented Jan 1, 2023

Over a period of time, there will be a good number of methods/scenario written and used across teams. When it's time to clean-up/refactor those scenario, it's important to know where they are used to assess impact and plan.

image

@fhoeben
Copy link
Collaborator

fhoeben commented Jan 2, 2023

To me this search seems a bit too limited (I prefer the full 'coverage' scan provided by the 'slimCoverage' test system in my plugin, but I assume this search could have its value too).

To me it is not immediately clear what the 'Scope' radio buttons do. I assume they allow a subtree to be searched, if one navigates to the search page from a nested page. But in your screenshot I see 'All' and 'FitNesseRoot' which I assume both will mean all pages will be searched. In that situation I don't think we should show the scope radio, since the user's selection makes no difference.
I don't believe there are any tests to ensure the scope selection affects the search results. Can you add some?

@suratdas
Copy link
Contributor Author

suratdas commented Jan 3, 2023

Thank you for your comment. I took the screenshot for "FitNesseRoot" but I tested using sub-suites. "FitNesseRoot" and "All" will be displayed only if we initiate the search from "FitNesseRoot" page. This is the default behavior even for text and properties search. I added tests for scope selection result.

@fhoeben
Copy link
Collaborator

fhoeben commented Jan 3, 2023

Can you add the new feature to the ReleaseNotes page also?

@suratdas
Copy link
Contributor Author

suratdas commented Jan 3, 2023

Release notes updated. Thanks.

@fhoeben fhoeben merged commit 1b52bd9 into unclebob:master Jan 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants