Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silverstripe 3.0 compatible version unavailable via composer #9

Open
tractorcow opened this issue May 15, 2013 · 3 comments
Open

Silverstripe 3.0 compatible version unavailable via composer #9

tractorcow opened this issue May 15, 2013 · 3 comments

Comments

@tractorcow
Copy link
Contributor

This can be resolved by branching #7 into a new version, 3.0.

You could also create a 3.1 branch, but we may as well keep it at root until 3.2 is out.

@tractorcow
Copy link
Contributor Author

Hi @unclecheese , I've created a branch you can pull into your repository. https://github.com/tractorcow/silverstripe-event-calendar/tree/3.0

I don't know how many people are relying on a 3.0 compatible version of this module, but just in case, this should help them out.

@surfjedi
Copy link

Hi Tractor cow - I have tried your 3.0 version in ss 3.0.5 but getting php error -
[12-Sep-2013 22:35:25 UTC] PHP Fatal error: Access level to Calendar::$db must be public (as in class Page) in /Applications/MAMP/htdocs/ssnz3/event_calendar/code/Calendar.php on line 3

Isnt this an error from modules for 3.1 being used in 3.0?

@tractorcow
Copy link
Contributor Author

Hi @surfjedi , are you sure you have the right version

Does your Calendar.php look like the below:

<?php

class Calendar extends Page {


    static $db = array(
        'DefaultDateHeader' => 'Varchar(50)',
        'OtherDatesCount' => 'Int',
        'RSSTitle' => 'Varchar(255)',
        'DefaultFutureMonths' => 'Int',
        'EventsPerPage' => 'Int',
        'DefaultView' => "Enum('today,week,,month,weekend,upcoming','upcoming')"
    );
// ...
}

The static without a modifier should be public by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants