Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grid field actions not available #10

Closed
jonom opened this issue Jul 30, 2015 · 5 comments
Closed

Grid field actions not available #10

jonom opened this issue Jul 30, 2015 · 5 comments

Comments

@jonom
Copy link
Contributor

jonom commented Jul 30, 2015

Hi UC,

The GridField 'Add Mock Data' form never seems to show up automatically for me - the only way I can get it is to manually add it to a GridField. Is there a trick to this? When I manually add it with $config->addComponent(new MockDataGenerator()); it shows up above the form but still works fine. Of course I'd rather not do it that way as I have to remove it before I publish the site.

screen shot 2015-07-30 at 1 54 57 pm

screen shot 2015-07-30 at 1 59 17 pm

@wernerkrauss
Copy link

Seems GridFieldConfig never calls $this->extend('updateConfig') yet? See https://github.com/unclecheese/silverstripe-mock-dataobjects/blob/master/code/extensions/MockDataObjectGridFieldConfig.php#L8

@jonom
Copy link
Contributor Author

jonom commented Aug 1, 2015

Ah you're right! Looks like this feature should be available from 3.2 onwards. @unclecheese do you want me to add a note to the ReadMe to that effect?

@jonom
Copy link
Contributor Author

jonom commented Aug 1, 2015

Wow the necessary change was merged in to master nearly 2 years ago! I sure hope SemVer helps make these types of changes available quicker in future.

@wernerkrauss
Copy link

Seems it's solved in SS3.2 now.

@unclecheese
Copy link
Owner

That's great news! I've been waiting ages for that PR to be released! Exciting that we'll finally get this without any extra config.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants