Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make_pr: Add regenerate-fixtures feature #18

Merged
merged 2 commits into from Aug 13, 2018
Merged

make_pr: Add regenerate-fixtures feature #18

merged 2 commits into from Aug 13, 2018

Conversation

unclenachoduh
Copy link
Collaborator

  • Add regenerate-fixtures feature
  • Document in README
  • Minor changes to test

Copy link
Owner

@zbraniecki zbraniecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Thank you!

.output()
.expect("Failed to format the output using `rustfmt`");
if !matches.is_present("ugly") {
println!("{:?}", "Yes");
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

leftover println

@coveralls
Copy link

coveralls commented Aug 13, 2018

Pull Request Test Coverage Report for Build 102

  • 3 of 6 (50.0%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.3%) to 90.323%

Changes Missing Coverage Covered Lines Changed/Added Lines %
make_pluralrules/src/main.rs 0 3 0.0%
Files with Coverage Reduction New Missed Lines %
make_pluralrules/src/main.rs 1 0.0%
Totals Coverage Status
Change from base Build 98: -0.3%
Covered Lines: 532
Relevant Lines: 589

💛 - Coveralls

@unclenachoduh unclenachoduh merged commit 52d72f5 into master Aug 13, 2018
@zbraniecki zbraniecki deleted the uglyfy branch March 29, 2019 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants