Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CCS811B #66

Closed
digimatt22 opened this issue Jan 13, 2020 · 9 comments
Closed

CCS811B #66

digimatt22 opened this issue Jan 13, 2020 · 9 comments
Labels
enhancement New feature or request

Comments

@digimatt22
Copy link

Is anyone working on porting the CCS811B driver over from esp-open-rtos? If not I may attempt in the near future and submit a PR as I will need it in an upcoming project. Great library!

@UncleRus
Copy link
Owner

UncleRus commented Jan 14, 2020

I may attempt in the near future and submit a PR

That's would be great!

@UncleRus
Copy link
Owner

I've ported this driver, see #67
Could you test it?

@digimatt22
Copy link
Author

Absolutely but it will be a few day as I am traveling to a conference. Will have access to the hardware again on Friday.

@digimatt22
Copy link
Author

I have begun testing the driver and found the following items. I will continue to work through them but wanted to give an update.

ccs811_init_desc -> port and addr are flipped compared to other libraries. I have changed their order to stay consistent with other implementations

ccs811_init_sensor -> within this function there is a write of no data to a specific register (CCS811_REG_APP_START) the i2c_dev_write_reg does not allow for this. I can disable this check but all future calls appear to fail once I have. I will continue to look into this, if you have seen this before and have devised a solution please let me know.

@UncleRus
Copy link
Owner

UncleRus commented Feb 2, 2020

I updated PR according to your comments

@UncleRus
Copy link
Owner

UncleRus commented Feb 5, 2020

@digimatt22 Any news on testing?

@digimatt22
Copy link
Author

Testing is paused right now as I wait for a new logic analyzer to arrive so I can see what’s going on vs guess. It arrives later this week.

@UncleRus UncleRus added the enhancement New feature or request label Jun 19, 2020
@UncleRus
Copy link
Owner

UncleRus commented Dec 13, 2020

I'm going to merge this driver as is in humble hope that someone will someday try to use it and be kind enough to create an issue in this repository if something goes wrong.

@trombik What do you think about this?

@trombik
Copy link
Collaborator

trombik commented Dec 13, 2020

I'm fine with it. I ordered a breakout module a week ago, to be delivered in another week or two.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants