Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created a wifi logger component for esp-idf, can be included in the components? #73

Closed
2 tasks done
VedantParanjape opened this issue Apr 14, 2020 · 6 comments
Closed
2 tasks done

Comments

@VedantParanjape
Copy link

VedantParanjape commented Apr 14, 2020

Device type

  • ESP32

Framework version

  • ESP-IDF latest master

I developed a esp-idf component which sends esp generated logs over to a PC through wifi. It can send through UDP, TCP and websocket. It's user selectable. If it's possible can it be included in your repo?

Link: https://github.com/VedantParanjape/esp-wifi-logger

Regards, Vedant

@UncleRus
Copy link
Owner

Personally, I like this. But I would like to know the opinion of @trombik.

@trombik
Copy link
Collaborator

trombik commented Apr 14, 2020

it is technically possible. but, why? would you explain the benefit? your library has its own repository, and your users can install it. what are you trying to solve?

@VedantParanjape
Copy link
Author

Hey

I just want to increase visibility, get people to use and contribute it It's okay if not.

Regards, Vedant

@trombik
Copy link
Collaborator

trombik commented Apr 15, 2020

I found this repository useful because it has many drivers for devices. a device driver, usually, doesn't require maintenance when the implementation gets mature because chip makers don't change their products often. on the other hand, protocols keep changing. new requirements arise, users ask new features, etc. it would be better for you to keep your repository.

I actually have a local branch in my fork to build curl. I gave up to merge the branch because it is too much work to maintain. if I ever publish my work, it would be its own repository, not in this repository.

as stated in README, we are trying to support ESP8266 and ESP32. but unfortunately, ESP8266 doesn't have same libraries in the base framework, often lagged behind. MQTT is a good example. it would be very hard for you to support ESP8266.

I do not own the repository. this is just my opinion.

@UncleRus
Copy link
Owner

Sakurai has the same rights in this repository as mine and his opinion has the same weight as mine. I regret to inform you that I am closing this issue.

@VedantParanjape
Copy link
Author

@trombik I respect your opinion, it's sensible. I agree with the points.

Regards, Vedant

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants