New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Second local declaration for res value. #8

Closed

marbalon opened this issue Mar 29, 2019 · 1 comment

marbalon commented Mar 29, 2019

Here is a bug in this function. Function returns ESP_OK in case of i2c_master_cmd_begin returns ESP_FAIL because it is stored in local res value.

esp-idf-lib/components/i2cdev/i2cdev.c

Line 201 in 125dbb3

    
           esp_err_t res = i2c_master_cmd_begin(dev->port, cmd, CONFIG_I2CDEV_TIMEOUT / portTICK_RATE_MS);

UncleRus closed this as completed in

63d779b

Owner

UncleRus commented Mar 30, 2019

Nice catch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment