Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: support for glob patterns #64

Closed
ain opened this issue Feb 26, 2014 · 7 comments
Closed

Feature: support for glob patterns #64

ain opened this issue Feb 26, 2014 · 7 comments

Comments

@ain
Copy link

ain commented Feb 26, 2014

Currently, using glob patterns will cause the task to fail with:

Running "uncss:dist" (uncss) task
Fatal error: Unable to write "dist/styles/{,*/}*.css" file (Error code: undefined).

Task:

uncss: {
  dist: {
    files: {
      'dist/styles/{,*/}*.css': ['dist/{**,}*.html']
    }
  }
}
@addyosmani
Copy link
Member

I think this is a legitimate feature request. I'll see if we have time to add it to the next release.

@ain
Copy link
Author

ain commented Mar 22, 2014

👍

@giakki
Copy link
Member

giakki commented Mar 22, 2014

We are already planning to implement this feature right into uncss (see ben-eb/gulp-uncss#5), that way all the wrappers could benefit from this!

@addyosmani
Copy link
Member

Sounds good to me. Thanks for letting us know, @giakki!

@sindresorhus
Copy link

@guillaumevincent
Copy link

@giakki you mean You plan to implement the feature into uncss :
uncss/uncss#51
you add a gulp-uncss issue already closed

Maybe it's good to close all feature in all uncss wrappers and keep only one open in uncss repo.

@ain
Copy link
Author

ain commented Apr 3, 2014

I've now tested the following task configuration to work:

    uncss: {
      dist: {
        files: {
          '<%= yeoman.dist %>/styles/main.css': ['<%= yeoman.dist %>/{,**/}*.html']
        }
      }
    }

and will therefore close this ticket.

Thanks guys!

@ain ain closed this as completed Apr 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants