Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please correct SOFT value for Thin Italic instance #259

Closed
thlinard opened this issue May 13, 2021 · 2 comments · Fixed by #262
Closed

Please correct SOFT value for Thin Italic instance #259

thlinard opened this issue May 13, 2021 · 2 comments · Fixed by #262

Comments

@thlinard
Copy link

thlinard commented May 13, 2021

The Thin Italic fvar instance has <coord axis="SOFT" value="100.0"/> while all other instances, Italic or Regular, have <coord axis="SOFT" value="0.0"/>

@aaronbell
Copy link
Contributor

Per fonttools/fontbakery#3213, the default opsz value should not be made elidable.

@thlinard
Copy link
Author

thlinard commented Jun 29, 2021

Indeed! There were inconsistencies at the time.

But the "9 pt SuperSoft Thin Italic" instance should be "9 pt Thin Italic", like the Regular instance "9 pt" (this is because the Thin Italic fvar instance has <coord axis="SOFT" value="100.0"/> while all other instances, Italic or Regular, have <coord axis="SOFT" value="0.0"/>).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants