Skip to content
This repository has been archived by the owner on Feb 17, 2023. It is now read-only.

feat: improve codegen compat, use var __component__ instead of var component #115

Merged
merged 1 commit into from Aug 9, 2021
Merged

feat: improve codegen compat, use var __component__ instead of var component #115

merged 1 commit into from Aug 9, 2021

Conversation

IndexXuan
Copy link
Contributor

@IndexXuan IndexXuan commented Aug 2, 2021

for userland code, If code like this, there will be variable conflicts.

import component from './HelloWorld2.vue'

component.name = 'HelloWorld2'

export default component

the genereated code will have var component which conflicts with user-defined vars.

image

this PR use __component__ for better compat with userland code.

@IndexXuan
Copy link
Contributor Author

@underfin plz review it. thank you.

@underfin underfin merged commit 77d3cac into underfin:master Aug 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants