Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_child_theme_variables.scss with the new bootstrap #97

Closed
akkolad opened this issue Sep 26, 2017 · 2 comments
Closed

_child_theme_variables.scss with the new bootstrap #97

akkolad opened this issue Sep 26, 2017 · 2 comments

Comments

@akkolad
Copy link
Contributor

akkolad commented Sep 26, 2017

The Bootstrap v4.0.0-beta is different now and the
$brand-primary: #000000; //#ff6d5a
doesn't work anymore, instead I've used this :

$gray-100: #f8f9fa;
$gray-600: #868e96;
$gray-800: #343a40;
$red: #dc3545;
$yellow: #ffc107;
$blue: #000000; // This is the only variable I wanted to change
$cyan: #17a2b8;
$green: #28a745;
$theme-colors: (
primary: $blue,
secondary: $gray-600,
success: $green,
info: $cyan,
warning: $yellow,
danger: $red,
light: $gray-100,
dark: $gray-800
);

but I'm not sure that this is the good way, I've seen that :

// In a custom variables file...
$theme-colors: (
primary: red
);
// In Bootstrap's _variables.scss file...
$theme-colors: () !default;
$theme-colors: map-merge((
primary: $blue,
secondary: $gray-600,
success: $green,
info: $cyan,
warning: $yellow,
danger: $red,
light: $gray-100,
dark: $gray-800
), $theme-colors);

(from twbs/bootstrap#23112)

But idem I'm not sure that this is the best solution.

Any ideas ?

@holger1411
Copy link
Contributor

Becaus of some bugs in Bootstrap 4 Beta 2 (especially incompatiblities with jQuery in noConflict mode which is used by WordPress) I did not update the child theme to the latest BS version.
Waiting for a fix from BS core team.

So the fix for your problem is currently not part of the child theme...

So the workaround you mentioned is the way to go at this state (looking forward to a new BS 4 Beta 3 release...)

@Thomas-A-Reinert
Copy link
Contributor

i guess this issue can be closed after nearly half a year without any responses now, correct? Feel free to reopen if neccessary!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants