UNDERTOW-1302 Fix response splitting flaw if headers contain non-asci…

…i characters
undertow-io · Apr 26, 2018 · 85d4478 · 85d4478
1 parent ea3f9de
commit 85d4478
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/core/src/main/java/io/undertow/server/protocol/http/HttpResponseConduit.java b/core/src/main/java/io/undertow/server/protocol/http/HttpResponseConduit.java
@@ -294,8 +294,9 @@ private static void writeString(ByteBuffer buffer, String string) {
         int length = string.length();
         for (int charIndex = 0; charIndex < length; charIndex++) {
             char c = string.charAt(charIndex);
-            if(c != '\r' && c != '\n') {
+            byte b = (byte) c;
-                buffer.put((byte) c);
+            if(b != '\r' && b != '\n') {
+                buffer.put(b);
             } else {
                 buffer.put((byte) ' ');
             }