Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multithreading in Windows #74

Closed
MarouaneMan opened this issue Aug 11, 2019 · 4 comments
Closed

Multithreading in Windows #74

MarouaneMan opened this issue Aug 11, 2019 · 4 comments

Comments

@MarouaneMan
Copy link

Hello,

First of all, thank you for this work, I gave it a test and it's blazing fast.
I just have a little problem, the current proposed multithreading solution has no effect on Windows because SO_REUSEPORT is not supported and does anything, so only one thread will get connections.
Is there anyway to implement multithreading in the listener?

Thank you.

@ghost
Copy link

ghost commented Aug 11, 2019

Hi,

It should work as is. I'm pretty certain I have tested this as some point, even though Windows is by far a third-class platform.

Definitely aim for Linux if you are interested in performance.

@MarouaneMan
Copy link
Author

I made a test again and unfortunately only the first created thread accepts connections.

Can't switch to linux for technical reasons but thanks anyway.

@MarouaneMan MarouaneMan reopened this Aug 21, 2019
@ghost ghost transferred this issue from uNetworking/uWebSockets Sep 6, 2019
@ghost
Copy link

ghost commented Jun 24, 2020

I've tested this on windows and it does accept connections on all threads. You don't get any particular guarantee but that's what happens if you load the system

@ghost
Copy link

ghost commented Jun 24, 2020

I can't do anything about this report

@ghost ghost closed this as completed Jun 24, 2020
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant