-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
abort immediate #7
Comments
This has been improved in v1.04 that I am going to upload today, but the abort button should never be able to be pressed outside of those states, so not sure why you need SetRelayFrequency(0); outside the if statement. It is inside the if statement in v1.04 :-) |
It was a safety thing, in case of a bug or loss of state , abort aborts always |
Right, but again, AbortReflow() is only ever called from a button press, and that press can only happen in those states...
|
I am always thinking about future abstraction less code coverage if abort gets called from a big red button or tc failure |
abort does not turn off heater immediately
SetRelayFrequency(0);
do not wait for return and loop
The text was updated successfully, but these errors were encountered: