Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Showing wrong wifi name when setup #158

Closed
1 task done
tastyrepublic opened this issue Oct 30, 2023 · 11 comments
Closed
1 task done

Showing wrong wifi name when setup #158

tastyrepublic opened this issue Oct 30, 2023 · 11 comments
Labels
bug Something isn't working core Core related issue

Comments

@tastyrepublic
Copy link

tastyrepublic commented Oct 30, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Description

When wifi SSID include the (‘s) character , the remote two can’t show it correctly, and can’t connect to it.

How to Reproduce

  1. Search for wifi in remote two setup page.

Expected behavior

Show wifi name that’s include (‘s) character.

System version

V1.4.3

What part of the system affected by the problem?

Core

Additional context

No response

@tastyrepublic tastyrepublic added the bug Something isn't working label Oct 30, 2023
@github-actions github-actions bot added the core Core related issue label Oct 30, 2023
@zehnm
Copy link

zehnm commented Oct 30, 2023

Which character is that exactly?

@tastyrepublic
Copy link
Author

Which character is that exactly?

Wifi name: Don’s wifi
But it show up like: Don\xe2\x80\x99s wifi
I never saw this in other devices.

@martonborzak
Copy link
Contributor

Please note also that newer firmware is available.

@tastyrepublic
Copy link
Author

Please note also that newer firmware is available.

Just updated to the latest version now by connecting to other wifi, problem still there.

@zehnm
Copy link

zehnm commented Oct 30, 2023

It's a Unicode encoding issue: \xe2\x80\x99 is UTF-8 for

U+2019 \xe2\x80\x99 RIGHT SINGLE QUOTATION MARK

So there's a missing encoding when retrieving the names... Sorry about that!
Let me setup my spare access point for testing 🤓

@tastyrepublic
Copy link
Author

Thank you for testing it out.

@tastyrepublic
Copy link
Author

So can I expect it will be fix at the next update? I still waiting to connect to the wifi so I can control my Apple TV and hue setup.

@zehnm
Copy link

zehnm commented Oct 31, 2023

We are working with high priority on this showstopper. It's much more complex than a simple encoding, which turned out not to be the issue. The wifi driver is already messing with the SSID name, if it doesn't contain plain text (anything else than ASCII 7-bit), and performs it's own character escaping.

The first fix will work with proper UTF-8 SSID names, as your network name.
However, there's much more to it, thanks to the "very special" SSID specification. Not many access points support such network names, but since we're at it, we try to get this covered as well.

@tastyrepublic
Copy link
Author

Really don’t know it need quite some works to fix it. Keep the great work👍🏻wait for the update.

@zehnm zehnm added this to the Roadmap October 2023 milestone Oct 31, 2023
@zehnm
Copy link

zehnm commented Nov 3, 2023

Closing: fixed in release 1.4.5
SSID with proper UTF-8 names are now working.

Restrictions:

  • non-UTF-8 SSIDs are not yet supported in the UI.
    (Most access points don't support using arbitrary byte characters in the SSID name, and IMHO shouldn't be used anyways 😅)
  • emojis are not supported.

@zehnm zehnm closed this as completed Nov 3, 2023
@tastyrepublic
Copy link
Author

Thank you so much. Will test it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working core Core related issue
Projects
Status: Done
Development

No branches or pull requests

3 participants