Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Can not use "/" character in IR button name #187

Closed
1 task done
bikeymouse opened this issue Nov 11, 2023 · 3 comments
Closed
1 task done

[bug] Can not use "/" character in IR button name #187

bikeymouse opened this issue Nov 11, 2023 · 3 comments
Assignees
Labels
bug Something isn't working ir Infrared releated issue web configurator Web configurator related issue

Comments

@bikeymouse
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Description

If want to create a new remote button that has a name containing the "/" character, I can not save the button with the IR code.
The interface responds with a "bad request" and gives no indication what is wrong.
slash-button

How to Reproduce

  1. Goto webconfig
  2. Click remotes
  3. Select remote
  4. Click pen-symbol on IR-data set
  5. Add a new name with a "/" in the box besides the "custom button" button
  6. Add an IR code or learn IR-code
  7. Click save

Expected behavior

Button should be saved or a proper error-resonse indicating what's wrong should be given.

System version

1.4.5

What part of the system affected by the problem?

Web Configurator

Additional context

No response

@bikeymouse bikeymouse added the bug Something isn't working label Nov 11, 2023
@github-actions github-actions bot added the web configurator Web configurator related issue label Nov 11, 2023
@zehnm
Copy link

zehnm commented Nov 29, 2023

Confirmed, a / character in the button name doesn't work for learning IR commands. This will be fixed in the next release.

The issue is only present on the remote device because of the reverse proxy. It decodes all encoded URLs by default and the reason we didn't caught it during development. Since the encoded IR command name is used in the URL as parameter, this then calls an unknown service endpoint. Instead of /api/remotes/:entityId/ir/test%2Ftest this was sent to the service: /api/remotes/:entityId/ir/test/test.

@zehnm zehnm self-assigned this Nov 29, 2023
@zehnm
Copy link

zehnm commented Dec 1, 2023

Included in BETA release group and soon available.

@zehnm zehnm added this to the Roadmap Q4 2023 milestone Dec 1, 2023
@zehnm zehnm added the ir Infrared releated issue label Dec 11, 2023
@zehnm
Copy link

zehnm commented Dec 14, 2023

Fixed in v1.5.2

@zehnm zehnm closed this as completed Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ir Infrared releated issue web configurator Web configurator related issue
Projects
Status: Done
Development

No branches or pull requests

2 participants