-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove remaining gatewayEdit specific components #10
Comments
Interesting... I expect crash and burn with the bible ref RCL missing... but all the GWE components apparently default to Matthew 1:1. So it still works... So I'll have to dig into the code to locate the components to remove... |
At this point, I think the best approach is to do the following:
Perhaps better, create three cards:
I like the last approach better, especially since it can be split out into 3 issues and worked in parallel. So in this issue, I'll simply delete some things and make a simple Text Card (or several) as placeholders for the others. |
@mandolyte Did you see the Paper component in translation-helps-RCL, it may be better for your use case than Card. Paper is just the UI part that could be reused to accomplish what you described above. See: https://github.com/unfoldingWord/translation-helps-rcl/tree/main/src/components/Paper |
@mannycolon About Paper vs Card... If I wanted to have resizability and draggability, which would I use? I'm sure I could find it, but I'm sure you know off the top of your head. Are there any other differences that should be considered? |
Both can be draggedand resized as long as you pass in the right classname, but the Paper component is only a div with shadow so it is bare bone, it has no features. |
Closed by above linked PR |
With the Bible Reference RCL removed, trying to use the app should now reveal all the gatewayEdit (GWE) components that depend on it.
These should all be removed.
Add a (new?) component that simply shows the uW logo in a resizable, draggable card component.
NOTE: the code for the Card component might be in the translation-helps-rcl... consider which is better:
The text was updated successfully, but these errors were encountered: