Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove remaining gatewayEdit specific components #10

Closed
mandolyte opened this issue Oct 21, 2021 · 7 comments · Fixed by #17
Closed

Remove remaining gatewayEdit specific components #10

mandolyte opened this issue Oct 21, 2021 · 7 comments · Fixed by #17
Assignees

Comments

@mandolyte
Copy link
Collaborator

With the Bible Reference RCL removed, trying to use the app should now reveal all the gatewayEdit (GWE) components that depend on it.

These should all be removed.

Add a (new?) component that simply shows the uW logo in a resizable, draggable card component.

NOTE: the code for the Card component might be in the translation-helps-rcl... consider which is better:

  • updating translation helps to make the Card component usable apart for the rest of the helps
  • making a new RCL with the Card functionality (resize and drag); and perhaps update the helps to use it as well
  • coping the code from helps to this template
@mandolyte mandolyte self-assigned this Oct 22, 2021
@mandolyte
Copy link
Collaborator Author

Interesting... I expect crash and burn with the bible ref RCL missing... but all the GWE components apparently default to Matthew 1:1. So it still works... So I'll have to dig into the code to locate the components to remove...

@mandolyte
Copy link
Collaborator Author

mandolyte commented Oct 22, 2021

At this point, I think the best approach is to do the following:

  • Delete (or rename--see below) the resource card component (/src/components/ResourceCard.js)
  • This will cause all sorts of errors in the workspace container component, which I can then work thru
  • Using the pattern of ResourceCard, create a Card that contains the following:
    • The uW logo
    • The value of selected org
    • The value of the selected language

Perhaps better, create three cards:

  1. A logo card
  2. An Org card with info about the selected org using: https://git.door43.org/api/v1/orgs/ru_gl
  3. A Language card with info about the selected language using https://td.unfoldingword.org/uw/languages/

I like the last approach better, especially since it can be split out into 3 issues and worked in parallel.

So in this issue, I'll simply delete some things and make a simple Text Card (or several) as placeholders for the others.

@mannycolon
Copy link
Contributor

@mandolyte Did you see the Paper component in translation-helps-RCL, it may be better for your use case than Card. Paper is just the UI part that could be reused to accomplish what you described above.

See: https://github.com/unfoldingWord/translation-helps-rcl/tree/main/src/components/Paper
See usage here: https://github.com/unfoldingWord/translation-helps-rcl/blob/main/src/components/Card/Card.js#L206

@mandolyte
Copy link
Collaborator Author

@mannycolon About Paper vs Card... If I wanted to have resizability and draggability, which would I use? I'm sure I could find it, but I'm sure you know off the top of your head.

Are there any other differences that should be considered?

@mannycolon
Copy link
Contributor

Both can be draggedand resized as long as you pass in the right classname, but the Paper component is only a div with shadow so it is bare bone, it has no features.

@mannycolon
Copy link
Contributor

@mandolyte

@mandolyte mandolyte linked a pull request Nov 1, 2021 that will close this issue
2 tasks
@mandolyte
Copy link
Collaborator Author

Closed by above linked PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants