Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid Hardcoding of Font Family #141

Open
mandolyte opened this issue Sep 13, 2022 · 0 comments
Open

Avoid Hardcoding of Font Family #141

mandolyte opened this issue Sep 13, 2022 · 0 comments

Comments

@mandolyte
Copy link
Contributor

The using app should control the font used by the RCL. Thus this should be a property that is provided by the app.

Currently, it is hard-coded. This is the code in Verse.js:

  const verseText = verseObjects.map(verseObject => verseObject.text).join('');
  const hebrew = isHebrew(verseText);
  let _dir = direction || 'auto';
  if (hebrew) {
    _dir = 'rtl';
  }

  const style = _dir === 'rtl' 
    ? { fontSize: `1.7em`, fontFamily: `EzraSILSRRegular` } 
    : { fontSize: `1em`, fontFamily: `Noto Sans`}  
  //const style = {};
  if (paragraphs) style.display = 'inline';
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant