Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Card Menu isn't working #24

Open
mandolyte opened this issue Nov 3, 2021 · 1 comment
Open

Card Menu isn't working #24

mandolyte opened this issue Nov 3, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@mandolyte
Copy link
Collaborator

The card menu today only provides a single action, namely to adjust the font size. When the menu is clicked, there is the console output:

react.development.js:220 Warning: Failed prop type: The prop `setFilters` is marked as required in `SettingsCard`, but its value is `undefined`.
    at SettingsCard (http://localhost:3000/_next/static/chunks/pages/_app.js?ts=1635938399312:287462:19)
    at Card (http://localhost:3000/_next/static/chunks/pages/_app.js?ts=1635938399312:286269:18)

The font size dialog actually opens:
image

The dialog is draggable, but if you attempt to use the slider, Next.js shows:
image

@mandolyte
Copy link
Collaborator Author

From discord conversation: probably not passing setFilters function as a prop to Card component. I suggest looking at the gateway-edit code to see how we implemented this. Will look into it.

(thanks @mannycolon )

@mandolyte mandolyte added the bug Something isn't working label Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant