Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nuget package missing new targets #1

Open
AGusty opened this issue Jul 23, 2015 · 5 comments
Open

Nuget package missing new targets #1

AGusty opened this issue Jul 23, 2015 · 5 comments

Comments

@AGusty
Copy link

AGusty commented Jul 23, 2015

Aspnet 5 needs dnx451 and dnxcore50 targets.

@unger
Copy link
Owner

unger commented Oct 29, 2015

I have some trouble getting it to work under dnxcore50, but the existing Nuget package works under dnx451. To resolve this in your Aspnet 5 project you can remove dnxcore50, from the frameworks listed in project.json. Hope this helps.

@AGusty
Copy link
Author

AGusty commented Dec 18, 2015

Thanks but my webapp uses .net core.
I created a new solution (I can email you) based on your AspNet5PackageLibrary branch.
Now all tests pass except those who use SetConvertMethod because Roslyn changed behavior of compiled lambdas (no more static method): http://stackoverflow.com/a/31651531
I think by now you may publish a beta version without SetConvertMethod.

@unger
Copy link
Owner

unger commented Dec 20, 2015

Great thanks, you can attach the file in a comment here, and I will take a look at it. I am aware of the SetConvertMethod issues with Roslyns changed handling of lambdas. I have made some changes regarding lambda functions in the latest master branch, I think that should fix those problems.

@AGusty
Copy link
Author

AGusty commented Jan 5, 2016

Sorry for delay. But I can't attach, is a zip but it seems that don't support that file type...

@unger
Copy link
Owner

unger commented Jan 12, 2016

Maybe you can try to make a pull request with the changes, that way it will probably be easier for me to merge the changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants