Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error when in directories w/o package.json & CHANGELOG.md #9

Closed
ungoldman opened this issue Mar 2, 2015 · 0 comments
Closed

error when in directories w/o package.json & CHANGELOG.md #9

ungoldman opened this issue Mar 2, 2015 · 0 comments

Comments

@ungoldman
Copy link
Owner

e.g.

∴ ng@crimelab ~/dev/github $ node ./gh-release/bin/cli.js

module.js:340
    throw err;
          ^
Error: Cannot find module '/Users/ng/dev/github/package.json'
    at Function.Module._resolveFilename (module.js:338:15)
    at Function.Module._load (module.js:280:25)
    at Module.require (module.js:364:17)
    at require (module.js:380:17)
    at getDefaults (/Users/ng/dev/github/gh-release/lib/get-defaults.js:6:13)
    at /Users/ng/dev/github/gh-release/bin/cli.js:68:3
    at auth (/Users/ng/dev/github/gh-release/node_modules/ghauth/ghauth.js:140:14)
    at Object.<anonymous> (/Users/ng/dev/github/gh-release/bin/cli.js:65:1)
    at Module._compile (module.js:456:26)
    at Object.Module._extensions..js (module.js:474:10)

getDefaults() shouldn't be called unless gh-release is being run in a valid directory. if the directory is invalid, gh-release should return an error message and/or usage info.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant