Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unicorn.util.smartHttp is really noisy #10

Open
tomodachi94 opened this issue Nov 2, 2022 · 1 comment
Open

unicorn.util.smartHttp is really noisy #10

tomodachi94 opened this issue Nov 2, 2022 · 1 comment
Assignees
@tomodachi94
Labels
bug Something isn't working library: util Applies to `unicorn.util`

Comments

@tomodachi94
Copy link
Member

The aforementioned function is really noisy; eg. it prints stuff whenever an HTTP request is made, and prints if the HTTP request succeeded.

We should probably only be noisy if there's an error.

Anyone is welcome to tackle this if they want, or I can do it.
@tomodachi94 tomodachi94 added bug Something isn't working good first issue Good for newcomers labels Nov 2, 2022
@tomodachi94 tomodachi94 added the library: util Applies to `unicorn.util` label Nov 11, 2022
@tomodachi94 tomodachi94 self-assigned this Dec 11, 2022
@tomodachi94
Copy link
Member Author

As mentioned in #33, I'm most likely going to redo unicorn.util.smartHttp.

@tomodachi94 tomodachi94 removed the good first issue Good for newcomers label Dec 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tomodachi94 tomodachi94

Labels
bug Something isn't working library: util Applies to `unicorn.util`
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tomodachi94