Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log everything #40

Open
tomodachi94 opened this issue Dec 19, 2022 · 7 comments
Open

Log everything #40

tomodachi94 opened this issue Dec 19, 2022 · 7 comments
Labels
enhancement New feature or request library: core Applies to `unicorn.core` library: provider Applies to `unicorn.provider.*` library: remote Applies to `unicorn.remote` library: util Applies to `unicorn.util`

Comments

@tomodachi94
Copy link
Member

Is your feature request related to a problem? Please describe.
Logging everything would make debugging easier.

Describe the solution you'd like
Everything should get logged into a file.

Additional context
In #27, we briefly discussed using Commandcracker's CC-Logger project.

This was suggested by @Apethesis in the MCCM Discord.
@tomodachi94 tomodachi94 added enhancement New feature or request library: core Applies to `unicorn.core` library: remote Applies to `unicorn.remote` library: util Applies to `unicorn.util` library: provider Applies to `unicorn.provider.*` labels Dec 19, 2022
@Apethesis
Copy link

could also use my logging lib

@tomodachi94
Copy link
Member Author

tomodachi94 commented Dec 19, 2022 •
edited
Loading

could also use my logging lib

Could you provide a link?

Edit: Never mind, it's available here.

@Commandcracker
Copy link
Contributor

It would be enough for now if we would have an setting like unicornpkg.debug or unicornpkg.verbosity. Then we would just print if it is enabled.

@Commandcracker
Copy link
Contributor

Commandcracker commented Sep 2, 2023 •
edited
Loading

If using my logging.lua in the future is planed, then adding something like unicornpkg.loglevel might even be better.

@Apethesis

This comment was marked as off-topic.

Sign in to view
@Commandcracker

This comment was marked as off-topic.

Sign in to view
@Apethesis

This comment was marked as off-topic.

Sign in to view
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request library: core Applies to `unicorn.core` library: provider Applies to `unicorn.provider.*` library: remote Applies to `unicorn.remote` library: util Applies to `unicorn.util`
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Commandcracker @tomodachi94 @Apethesis