Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ivy.conj #28311

Closed
ZenithFlux opened this issue Feb 17, 2024 · 3 comments
Closed

ivy.conj #28311

ZenithFlux opened this issue Feb 17, 2024 · 3 comments
Assignees
Labels
Ivy API Experimental Run CI for testing API experimental/New feature or request Next Release This issue or PR should only be considered once the next release is out. Suggestion A suggestion rather than a detected issue or a definitive task Useful Issue An issue created outside of the open tasks which adds value to the repository

Comments

@ZenithFlux
Copy link
Contributor

Why should this be implemented?

  • 3+ of the native frameworks have this function
  • it's needed for a complex/long frontend function implementation

Links to native framework implementations

@ZenithFlux ZenithFlux added Ivy API Experimental Run CI for testing API experimental/New feature or request Next Release This issue or PR should only be considered once the next release is out. Suggestion A suggestion rather than a detected issue or a definitive task labels Feb 17, 2024
@NripeshN NripeshN added the Useful Issue An issue created outside of the open tasks which adds value to the repository label Feb 19, 2024
@vedpatwardhan
Copy link
Contributor

Hey @ZenithFlux, could you please share if there's a specific model which contains this function? Over the past few weeks/months we've been trying to move the effort more towards fixing existing functions rather than adding new ones, unless the function needs to be added for some model to be transpilable. Thanks 😄

@ZenithFlux
Copy link
Contributor Author

@vedpatwardhan Sorry for late reply, I totally forgot about this issue. Actually I needed this function to implement torch.linalg.householder_product for tensorflow. The tensorflow has tfp.bijectors.Householder but its not exactly same as torch one.

It was the first issue I picked up, but I later realized that it might not be necessary to implement in ivy right now as ivy needs to make the basic functionalities work first. It is quite a niche function, it can be added later.

@vedpatwardhan
Copy link
Contributor

vedpatwardhan commented Mar 20, 2024

yep sounds good, I'll probably close this issue for now in that case, thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ivy API Experimental Run CI for testing API experimental/New feature or request Next Release This issue or PR should only be considered once the next release is out. Suggestion A suggestion rather than a detected issue or a definitive task Useful Issue An issue created outside of the open tasks which adds value to the repository
Projects
None yet
Development

No branches or pull requests

4 participants