reformatting task coding challenge #9404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivy-leaves
added
Array API
added pre-commit hook
removing linting erros
fnhirwa
suggested changes
Jan 11, 2023
There was a problem hiding this comment.
Hi
Thanks for contributing to ivy😊
An overview of this task is that these functions won't need to have array and container methods so you can remove them.
And as the functions are private, this means they won't be rendered in docs we can write simple docstring explaining functions with no need for putting examples.
Thanks🙂
removed array and container implementations
fnhirwa
suggested changes
Jan 12, 2023
removed decorator
|
Thank you for your patience. I have removed the decorator. Please review the work at your convenience. |
fnhirwa
suggested changes
Jan 12, 2023
fnhirwa
approved these changes
Jan 12, 2023
vedpatwardhan
pushed a commit
to vedpatwardhan/ivy
that referenced
this pull request
Feb 23, 2023
vedpatwardhan
pushed a commit
to vedpatwardhan/ivy
that referenced
this pull request
Feb 26, 2023
vedpatwardhan
pushed a commit
to vedpatwardhan/ivy
that referenced
this pull request
Feb 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please consider this my PR for the task 'vairable_data' in the 'gradients' submodule.
The task number #9283 and the ToDo list is #776
close #9283