Adding Cos, Sin, Acos, Sigmoid to PyTorch Frontend #2471

pritam1322 · 2022-07-30T19:31:59Z

Add Pointwise ops to PyTorch Frontend #12

iamjameskeane

Hi can you please make the requested changes and re request a review :)

iamjameskeane · 2022-07-31T20:33:30Z

.idea/runConfigurations/pytest_for_elementwise.xml

@@ -4,7 +4,7 @@
    <option name="INTERPRETER_OPTIONS" value="" />
    <option name="PARENT_ENVS" value="true" />
    <option name="SDK_HOME" value="" />
-    <option name="WORKING_DIRECTORY" value="" />
+    <option name="WORKING_DIRECTORY" value="$PROJECT_DIR$" />


Can you please remove this change :)

iamjameskeane · 2022-07-31T20:33:44Z

.idea/runConfigurations/pytest_for_functional_core.xml

@@ -4,7 +4,7 @@
    <option name="INTERPRETER_OPTIONS" value="" />
    <option name="PARENT_ENVS" value="true" />
    <option name="SDK_HOME" value="" />
-    <option name="WORKING_DIRECTORY" value="" />
+    <option name="WORKING_DIRECTORY" value="$PROJECT_DIR$" />


Please remove this changes also

ivy_tests/test_ivy/test_functional/test_core/test_elementwise.py

pritam1322 · 2022-08-01T07:12:11Z

ivy_tests/test_ivy/test_functional/test_core/test_elementwise.py
There are no change in this file, uploaded it by mistake.

iamjameskeane · 2022-08-01T09:01:17Z

Hi @pritam1322,

It looks like you are implementing multiple functions yet you have only requested to do cos(). You would need to request to do the other functions from here before pushing their implementations. Alternatively you can just implement cos in this PR and then request to do others after it has been merged :)

Thanks,
James

pritam1322 · 2022-08-01T14:12:47Z

cos #2467
sin #2533
acos #2535
sigmoid #2480

iamjameskeane

In this PR you are still deleting the contents of file in .idea. In order to correct this you need to revert them back to how they are on Ivy/master locally and push the change.

Once you have done this request a review and I will review your implementations

iamjameskeane · 2022-08-01T08:57:34Z

ivy_tests/test_ivy/test_functional/test_core/test_elementwise.py

@@ -1,2175 +0,0 @@
-"""Collection of tests for elementwise functions."""


In this PR this is still a change to delete the contents of this file. Please undo.

I can't undo it. Should I add it again

iamjameskeane · 2022-08-01T08:57:43Z

.idea/runConfigurations/pytest_for_functional_core.xml

@@ -1,48 +0,0 @@
-<component name="ProjectRunConfigurationManager">


In this PR this is still a change to delete the contents of this file. Please undo.

This is still an issue you need to revert this file to how it was on Ivy/master

iamjameskeane · 2022-08-01T08:57:51Z

.idea/runConfigurations/pytest_for_elementwise.xml

@@ -1,48 +0,0 @@
-<component name="ProjectRunConfigurationManager">


In this PR this is still a change to delete the contents of this file. Please undo.

This is still an issue you need to revert this file to how it was on Ivy/master

This reverts commit 5623ddf.

This reverts commit b77cb90.

This reverts commit e154812.

iamjameskeane

Hi,

You have some lint errors with this commit. You can install a pre-commit hook as documented here. To prevent these errors in the future. The issues are highlighted in the GitHub action here. Please make the corrections for any files that are included in this commit.

Finally there are test failures for the functions you have implemented here. You need to have the tests passing before I can merge to master.

Thanks,
James

iamjameskeane

Please see requested changes :). I am also seeing some lint errors regarding the files you have been working on, if you haven't already please install a pre commit hook as documented here. This will prevent any lint errors.

iamjameskeane · 2022-08-04T08:33:23Z

ivy/functional/frontends/torch/non_linear_activation_functions.py

+
+def sigmoid(input, out=None):
+    return ivy.sigmoid(input, out=out)
+


add float 16 as unsupported data type here

iamjameskeane · 2022-08-04T08:35:11Z

ivy_tests/test_ivy/test_frontends/test_torch/test_non_linear_activation_functions.py

+):
+    input_dtype, x = dtype_and_x
+
+    if input_dtype == "float16":


We shouldn't skip any testing scenarios in the testing body. Please remove. See above for fix for this data type.

pritam1322 · 2022-08-04T10:24:52Z

Please see requested changes :). I am also seeing some lint errors regarding the files you have been working on, if you haven't already please install a pre commit hook as documented here. This will prevent any lint errors.

I have installed pre-commit and it gets check during push, but still getting lint error

pritam1322 · 2022-08-04T18:59:12Z

Should I create separate PR for each function? Things are getting mixed up.

pritam1322 · 2022-08-04T19:37:31Z

Lint run successfully

iamjameskeane · 2022-08-05T13:21:18Z

Yep this looks good to me and all tests passing.

Thanks!

Added cos and sin Pointwise ops to PyTorch Frontend

64d3fed

github-actions bot assigned iamjameskeane Jul 30, 2022

pritam1322 closed this Jul 30, 2022

pritam1322 reopened this Jul 30, 2022

pritam1322 added 2 commits July 31, 2022 01:36

Added acos to Pointwise Ops to Pytorch Frontend

f5d4280

Delete test_elementwise.py

5623ddf

iamjameskeane suggested changes Jul 31, 2022

View reviewed changes

iamjameskeane linked an issue Jul 31, 2022 that may be closed by this pull request

Add Pointwise ops to PyTorch Frontend #12

Open

pritam1322 added 2 commits August 1, 2022 12:36

Delete pytest_for_elementwise.xml

b77cb90

Delete pytest_for_functional_core.xml

e154812

pritam1322 requested a review from iamjameskeane August 1, 2022 07:12

pritam1322 added 2 commits August 2, 2022 00:41

Non-linear Activation Function #sigmoid

bba58e6

Merge remote-tracking branch 'origin/master' into master

dc64266

pritam1322 mentioned this pull request Aug 1, 2022

cos #2467 #2547

Closed

pritam1322 closed this Aug 2, 2022

pritam1322 reopened this Aug 2, 2022

iamjameskeane suggested changes Aug 2, 2022

View reviewed changes

iamjameskeane changed the title ~~Added cos and sin Pointwise ops to PyTorch Frontend~~ Adding Cos, Sin, Acos, Sigmoid to PyTorch Frontend Aug 2, 2022

This was linked to issues Aug 2, 2022

sin #2533

Closed

acos #2535

Closed

sigmoid #2480

Closed

cos #2467

Closed

iamjameskeane removed a link to an issue Aug 2, 2022

Add Pointwise ops to PyTorch Frontend #12

Open

pritam1322 added 4 commits August 2, 2022 21:57

Revert "Delete test_elementwise.py"

5bf454c

This reverts commit 5623ddf.

Revert "Delete pytest_for_elementwise.xml"

d4429c1

This reverts commit b77cb90.

Revert "Delete pytest_for_functional_core.xml"

2522763

This reverts commit e154812.

Non-linear Activation Function #sigmoid

eaaa937

pritam1322 and others added 2 commits August 2, 2022 22:31

Deleted files

cbed1ee

Merge branch 'master' into master

b3f6a20

iamjameskeane suggested changes Aug 3, 2022

View reviewed changes

Updated

f0a0c68

pritam1322 requested a review from iamjameskeane August 3, 2022 20:54

pritam1322 added 5 commits August 4, 2022 02:27

Update test_pointwise_ops.py

ff73e0e

Update test_pointwise_ops.py

21368b0

Update test_pointwise_ops.py

76d6efd

Update test_elementwise.py

e4135e3

Updated sigmoid in test_non_linear_activation_functions.py

c0c795c

iamjameskeane suggested changes Aug 4, 2022

View reviewed changes

Updated test_non_linear_activation_functions.py

761a427

pritam1322 closed this Aug 4, 2022

pritam1322 reopened this Aug 4, 2022

pritam1322 requested a review from iamjameskeane August 4, 2022 10:26

Update pointwise_ops.py

cc8b020

pritam1322 added 2 commits August 5, 2022 00:37

Update pointwise_ops.py

aa411fd

Update pointwise_ops.py

48e30a2

iamjameskeane merged commit 6115f87 into Transpile-AI:master Aug 5, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding Cos, Sin, Acos, Sigmoid to PyTorch Frontend #2471

Adding Cos, Sin, Acos, Sigmoid to PyTorch Frontend #2471

pritam1322 commented Jul 30, 2022 •

edited

iamjameskeane left a comment •

edited

iamjameskeane Jul 31, 2022

pritam1322 Aug 1, 2022

iamjameskeane Jul 31, 2022

pritam1322 commented Aug 1, 2022

iamjameskeane commented Aug 1, 2022

pritam1322 commented Aug 1, 2022 •

edited

iamjameskeane left a comment

iamjameskeane Aug 1, 2022

pritam1322 Aug 2, 2022

pritam1322 Aug 2, 2022

iamjameskeane Aug 1, 2022

iamjameskeane Aug 2, 2022

pritam1322 Aug 2, 2022

iamjameskeane Aug 1, 2022

iamjameskeane Aug 2, 2022

pritam1322 Aug 2, 2022

iamjameskeane left a comment

iamjameskeane left a comment •

edited

iamjameskeane Aug 4, 2022

iamjameskeane Aug 4, 2022

pritam1322 commented Aug 4, 2022 •

edited

pritam1322 commented Aug 4, 2022

pritam1322 commented Aug 4, 2022

iamjameskeane commented Aug 5, 2022

		@@ -1,2175 +0,0 @@
		"""Collection of tests for elementwise functions."""

		@@ -1,48 +0,0 @@
		<component name="ProjectRunConfigurationManager">


		def sigmoid(input, out=None):
		return ivy.sigmoid(input, out=out)

Adding Cos, Sin, Acos, Sigmoid to PyTorch Frontend #2471

Adding Cos, Sin, Acos, Sigmoid to PyTorch Frontend #2471

Conversation

pritam1322 commented Jul 30, 2022 • edited

iamjameskeane left a comment • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pritam1322 commented Aug 1, 2022

iamjameskeane commented Aug 1, 2022

pritam1322 commented Aug 1, 2022 • edited

iamjameskeane left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

iamjameskeane left a comment

Choose a reason for hiding this comment

iamjameskeane left a comment • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pritam1322 commented Aug 4, 2022 • edited

pritam1322 commented Aug 4, 2022

pritam1322 commented Aug 4, 2022

iamjameskeane commented Aug 5, 2022

pritam1322 commented Jul 30, 2022 •

edited

iamjameskeane left a comment •

edited

pritam1322 commented Aug 1, 2022 •

edited

iamjameskeane left a comment •

edited

pritam1322 commented Aug 4, 2022 •

edited