Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added the tensor operations for slicing, mutations, joinings and indexing #26558

Closed
wants to merge 15 commits into from
Closed

feat: added the tensor operations for slicing, mutations, joinings and indexing #26558

wants to merge 15 commits into from

Conversation

Sanjay8602
Copy link

@Sanjay8602 Sanjay8602 commented Oct 4, 2023 •
edited

PR Description

Related Issue

Close #

Checklist

  • Did you add a function? : yes I added the task for
  • Did you add the tests?
  • Did you run your tests and are your tests passing?
  • Did pre-commit not fail on any check?
  • Did you follow the steps we provided?

Socials

github-actions[bot]
github-actions bot reviewed Oct 4, 2023
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks

Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.

Issue Reference

In order to be considered for merging, the pull request description must refer to a specific issue number. This is described in our contributing guide and our PR template.
This check is looking for a phrase similar to: "Fixes #XYZ" or "Resolves #XYZ" where XYZ is the issue number that this PR is meant to address.

github-actions[bot]
github-actions bot reviewed Oct 4, 2023
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first Pull Request and thanks for supporting Ivy! 🎉
Join the conversation in our Discord

Here are some notes to understand our tests:

  • We have merged all the tests in one file called `display_test_results` job. 👀 It contains the following two sections:
    • Combined Test Results: This shows the results of all the ivy tests that ran on the PR. ✔️
    • New Failures Introduced: This lists the tests that fails on this PR.

Please make sure they are passing. 💪

Keep in mind that we will assign an engineer for this task and they will look at it based on the workload that they have, kindly be patient 😄.

@ivy-leaves ivy-leaves added Array API Conform to the Array API Standard, created by The Consortium for Python Data API Standards Ivy API Experimental Run CI for testing API experimental/New feature or request Paddle Frontend Developing the Paddle Frontend, checklist triggered by commenting add_frontend_checklist PyTorch Frontend Developing the PyTorch Frontend, checklist triggered by commenting add_frontend_checklist Ivy Functional API NumPy Frontend Developing the NumPy Frontend, checklist triggered by commenting add_frontend_checklist labels Oct 4, 2023
@ivy-leaves
Copy link

If you are working on an open task, please edit the PR description to link to the issue you've created.

For more information, please check ToDo List Issues Guide.

Thank you 🤗

@Sanjay8602
Copy link
Author

sir what I need to do changes as it is my first contribution on ivy

@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2023 •
edited

Thank you for this PR, here is the CI results:

This pull request does not result in any additional test failures. Congratulations!

hello-fri-end
hello-fri-end suggested changes Oct 9, 2023
View reviewed changes
Copy link
Contributor

@hello-fri-end hello-fri-end left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Sanjay8602, thanks for creating this PR. For starters, could you please link the issue you're trying to fix in this PR and also update the tittle to match the name of the function you're implementing. Also, please undo unrelated changes from all the files. Thanks :)

Sanjay8602
Sanjay8602 commented Oct 9, 2023
View reviewed changes
Copy link
Author

@Sanjay8602 Sanjay8602 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have made changes such as by mistake I added some so have deleted all those files

@Sanjay8602 Sanjay8602 changed the title Sanjay Sanjay Oct 9, 2023
Sanjay8602
Sanjay8602 commented Oct 9, 2023
View reviewed changes
Copy link
Author

@Sanjay8602 Sanjay8602 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

feat: added the tensor operations for slicing, mutations, joinings.

@ivy-branch @Sanjay8602
🤖 Lint code
0061c01 
feat: added the tensor operations
@Sanjay8602 Sanjay8602 changed the title Sanjay feat: added the tensor operations for slicing, mutations, joinings and indexing Oct 11, 2023
@Sanjay8602
Copy link
Author

Hey @Sanjay8602, thanks for creating this PR. For starters, could you please link the issue you're trying to fix in this PR and also update the tittle to match the name of the function you're implementing. Also, please undo unrelated changes from all the files. Thanks :)

Sir I have made some changes please have a look again please

hello-fri-end
hello-fri-end reviewed Oct 16, 2023
View reviewed changes
Copy link
Contributor

@hello-fri-end hello-fri-end left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Sanjay8602, could you please link the issue that this PR is attempting to fix?

@Sanjay8602
Copy link
Author

Hey @Sanjay8602, could you please link the issue that this PR is attempting to fix?

Hey @Sanjay8602, could you please link the issue that this PR is attempting to fix?

#26245

Sanjay8602
Sanjay8602 commented Oct 16, 2023
View reviewed changes
Copy link
Author

@Sanjay8602 Sanjay8602 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deleted files which I dont want in this PR

@Sanjay8602 Sanjay8602 changed the title feat: added the tensor operations for slicing, mutations, joinings and indexing feat: added the tensor operations for slicing, mutations, joinings and indexing #9 Oct 16, 2023
@Sanjay8602 Sanjay8602 changed the title feat: added the tensor operations for slicing, mutations, joinings and indexing #9 feat: added the tensor operations for slicing, mutations, joinings and indexing Oct 16, 2023
@Sanjay8602 Sanjay8602 closed this Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions left review comments

@hello-fri-end hello-fri-end hello-fri-end requested changes

Assignees

@hello-fri-end hello-fri-end

Labels
Array API Conform to the Array API Standard, created by The Consortium for Python Data API Standards Ivy API Experimental Run CI for testing API experimental/New feature or request Ivy Functional API NumPy Frontend Developing the NumPy Frontend, checklist triggered by commenting add_frontend_checklist Paddle Frontend Developing the Paddle Frontend, checklist triggered by commenting add_frontend_checklist PyTorch Frontend Developing the PyTorch Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Sanjay8602 @ivy-leaves @hello-fri-end @ivy-branch