Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added the select_scatter function to torch frontend #27061

Closed
wants to merge 2 commits into from

Conversation

lazyCodes7
Copy link

PR Description

Related Issue

Closes #26519

Checklist

  • Did you add a function?
  • Did you add the tests?
  • Did you run your tests and are your tests passing?
  • Did pre-commit not fail on any check?
  • Did you follow the steps we provided?

Socials

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks

Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.

Protected Branch

In order to be considered for merging, the pull request changes must not be implemented on the "main" branch. This is described in our Contributing Guide. We are closing this pull request and we would suggest that you implement your changes as described in our Contributing Guide and open a new pull request.

Conventional Commit PR Title

In order to be considered for merging, the pull request title must match the specification in conventional commits. You can edit the title in order for this check to pass.
Most often, our PR titles are something like one of these:

  • docs: correct typo in README
  • feat: implement dark mode"
  • fix: correct remove button behavior

Linting Errors

  • Found type "null", must be one of "feat","fix","docs","style","refactor","perf","test","build","ci","chore","revert"
  • No subject found

@lazyCodes7 lazyCodes7 changed the title (Draft) feat: select_scatter for torch frontend feat: select_scatter for torch frontend Oct 17, 2023
@lazyCodes7 lazyCodes7 changed the title feat: select_scatter for torch frontend feat: add select_scatter to PyTorch frontend #24377 Oct 17, 2023
@lazyCodes7 lazyCodes7 changed the title feat: add select_scatter to PyTorch frontend #24377 feat: add select_scatter to PyTorch frontend Oct 17, 2023
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first Pull Request and thanks for supporting Ivy! 🎉
Join the conversation in our Discord.

For every PR opened, we run unit tests and comment the results in the PR to ensure the functionality remains intact.
Please make sure they are passing. 💪

If you want to check them from the action runners, you can open the display_test_results job. 👀
It contains the following two sections:

  • Combined Test Results: This shows the results of all the ivy tests that ran on the PR. ✔️
  • New Failures Introduced: This lists the tests that fail on this PR.

Keep in mind that we will assign an engineer for this task and they will look at it based on the workload that they have, kindly be patient 😄.

@ivy-leaves ivy-leaves added the PyTorch Frontend Developing the PyTorch Frontend, checklist triggered by commenting add_frontend_checklist label Oct 17, 2023
@github-actions
Copy link
Contributor

Thank you for this PR, here is the CI results:


This pull request does not result in any additional test failures. Congratulations!

@lazyCodes7 lazyCodes7 changed the title feat: add select_scatter to PyTorch frontend feat: add select_scatter to PyTorch frontend. Oct 18, 2023
@lazyCodes7 lazyCodes7 changed the title feat: add select_scatter to PyTorch frontend. feat: added the select_scater function to torch frontend Oct 18, 2023
@lazyCodes7 lazyCodes7 changed the title feat: added the select_scater function to torch frontend feat: added the select_scatter function to torch frontend Oct 18, 2023
@lazyCodes7
Copy link
Author

Hi @kurshakuz ,
I am contributing to this repository for the very first time. If I am missing something that needs to be done please do let me know assuming you are the point of contact for this.

Copy link
Contributor

@kurshakuz kurshakuz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! Thank you for your contribution!

Your implementation is currently throwing the following error. Can you please resolve it?

ERROR ivy_tests/test_ivy/test_frontends/test_torch/test_indexing_slicing_joining_mutating_ops.py - AttributeError: module 'ivy.functional.backends.numpy' has no attribute 'bool'

@lazyCodes7
Copy link
Author

Hey @kurshakuz. I have been getting that error when I initially set up my environment as well. When I asked in one of the discord channels I was suggested to ignore it as numpy changed syntax for np.bool to np.bool_

Reference:
https://stackoverflow.com/questions/74893742/how-to-solve-attributeerror-module-numpy-has-no-attribute-bool

Possible fix is to set np.bool = np._bool but I am not sure if that is a good idea

@Ishticode
Copy link
Contributor

Thank you very much for the PR @lazyCodes7. Sorry for the delays on our end. You are right about the numpy bool issue.
Can you please resolve the conflict (and request a review) so that the ci can be frshly run. Thanks for your patience.

@Ishticode
Copy link
Contributor

Thank you very much for the PR. Closing this due to lack of activity with changes requested remaining unresolved for over 6 months. Please feel free to reopen if you would like to continue working on this. :)

@Ishticode Ishticode closed this Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PyTorch Frontend Developing the PyTorch Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

select_scatter
5 participants