Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed passing of missing backend argument in few function calls #27809

Merged
merged 1 commit into from
Jan 7, 2024

Conversation

Sai-Suraj-27
Copy link
Contributor

PR Description

In few files, in some of the function calls, the mandatory key-word argument backend is missing:
like in the following cases:
https://github.com/unifyai/ivy/blob/b5422a79808a860068e63d11233b0c0a2461d30f/ivy_tests/test_ivy/test_frontends/test_torch/test_tensor.py#L10194
https://github.com/unifyai/ivy/blob/b5422a79808a860068e63d11233b0c0a2461d30f/ivy_tests/test_ivy/test_frontends/test_torch/test_tensor.py#L10195

From the definition of flatten_and_to_np I see that backend is a mandatory key-word argument.
https://github.com/unifyai/ivy/blob/b5422a79808a860068e63d11233b0c0a2461d30f/ivy_tests/test_ivy/helpers/function_testing.py#L2408
So, I see that this argument is missing at few places when calling helpers.flatten_and_to_np() I think at all these places backend=backend_fw should be passed.

Related Issue

Closes #27110

Checklist

  • Did you add a function?
  • Did you add the tests?
  • Did you run your tests and are your tests passing?
  • Did pre-commit not fail on any check?
  • Did you follow the steps we provided?

Socials

@Sai-Suraj-27
Copy link
Contributor Author

@vedpatwardhan this is similar to this PR (#27133) that you reviewed which we discussed here (#27109). Please look into this, and a similar one (#27808) thank you.

@ivy-leaves ivy-leaves added TensorFlow Frontend Developing the TensorFlow Frontend, checklist triggered by commenting add_frontend_checklist PyTorch Frontend Developing the PyTorch Frontend, checklist triggered by commenting add_frontend_checklist labels Dec 28, 2023
@vedpatwardhan
Copy link
Contributor

lgtm! Feel free to merge the PR @NiteshK84, thanks @Sai-Suraj-27 😄

@soma2000-lang soma2000-lang merged commit 7fc9a4f into Transpile-AI:main Jan 7, 2024
395 of 413 checks passed
@soma2000-lang soma2000-lang self-assigned this Jan 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PyTorch Frontend Developing the PyTorch Frontend, checklist triggered by commenting add_frontend_checklist TensorFlow Frontend Developing the TensorFlow Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing mandatory keyword argument backend in function calls.
5 participants