Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed passing of un-necessary argument dtype #27880

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

Sai-Suraj-27
Copy link
Contributor

PR Description

In the following function call, the argument dtype is un-necessarily passed
https://github.com/unifyai/ivy/blob/3318cd16ec60a05a467393c64afbdd65d46ce2de/ivy/functional/frontends/paddle/tensor/tensor.py#L563-L566
From the actual function definition of ivy.all(), there is no argument dtype
https://github.com/unifyai/ivy/blob/3318cd16ec60a05a467393c64afbdd65d46ce2de/ivy/functional/ivy/utility.py#L28-L35
Also, from the PaddlePaddle docs we can see that there is no dtype argument for the all() function.
https://www.paddlepaddle.org.cn/documentation/docs/en/api/paddle/all_en.html#all

Related Issue

Closes #27879

Checklist

  • Did you add a function?
  • Did you add the tests?
  • Did you run your tests and are your tests passing?
  • Did pre-commit not fail on any check?
  • Did you follow the steps we provided?

Socials

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks Passed!

@Sai-Suraj-27 Sai-Suraj-27 changed the title Fixed passing of un-necessary argument dtype in ivy.all() function call fix: Fixed passing of un-necessary argument dtype Jan 9, 2024
@ivy-leaves ivy-leaves added the Paddle Frontend Developing the Paddle Frontend, checklist triggered by commenting add_frontend_checklist label Jan 9, 2024
@KareemMAX
Copy link
Contributor

This is valid, also want to add this doc for reference. As this is paddle.Tensor not paddle.all: https://www.paddlepaddle.org.cn/documentation/docs/en/api/paddle/Tensor_en.html#all

@KareemMAX KareemMAX merged commit b9cb39b into Transpile-AI:main Jan 9, 2024
264 of 281 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Paddle Frontend Developing the Paddle Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Un-necessary argument dtype passed in function call ivy.all()
4 participants