Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix tf get item with non 0 dim tensor queries #27921

Merged
merged 1 commit into from
Jan 16, 2024

Conversation

mattbarrett98
Copy link
Contributor

fixes something like the following:

import ivy
ivy.set_tensorflow_backend()
x = ivy.array([[0.]])
print(x[(slice(None, None, None), ivy.array([0]))])

where non 0 dimensional tensors are used in the query. there was a check filtering out non 0 dim boolean tensors, but i think this needs to be extensed to any non 0 dim tensor, as i've done. I also believe the fix you made @Ishticode is no longer necessary after this fix, so i removed this as well. Do you think we can add some of these cases to the get item tests @Ishticode ?

@vedpatwardhan
Copy link
Contributor

lgtm! Feel free to merge the PR, thanks @mattbarrett98 😄

@Ishticode Ishticode merged commit 868f13b into Transpile-AI:main Jan 16, 2024
108 of 141 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants