Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add stack frontends.torch #2990

Merged
merged 13 commits into from Aug 18, 2022
Merged

add stack frontends.torch #2990

merged 13 commits into from Aug 18, 2022

Conversation

Creative-Ataraxia
Copy link
Contributor

link to issue: #2631

@Creative-Ataraxia
add stack
ff30b77 
to frontends.torch
@Creative-Ataraxia
add test_stack
331bbe4 
to test_frontend.torch
@sreegandh804
Copy link
Contributor

Hey @PatternFinder , could you try and get the tests related to your function passing? 🙂

@Creative-Ataraxia
Copy link
Contributor Author

Hey @PatternFinder , could you try and get the tests related to your function passing? 🙂

Hi @sreegandh804, I've resolved all the errors on this stack function in the test-frontend-torch / run-nightly-tests (pull_request); please have a look if anything needs to be done :)

@sreegandh804
Copy link
Contributor

lgtm !

@sreegandh804 sreegandh804 merged commit d35496d into Transpile-AI:master Aug 18, 2022
@Creative-Ataraxia
Copy link
Contributor Author

thanks :) see you in other PRs

@Creative-Ataraxia Creative-Ataraxia deleted the add-stack-frontends.torch branch August 18, 2022 09:07
@sreegandh804 sreegandh804 linked an issue Aug 30, 2022 that may be closed by this pull request
stack #2631
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sreegandh804 sreegandh804

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

stack
2 participants
@Creative-Ataraxia @sreegandh804