Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Torch Lcm Frontend #4972

Closed
wants to merge 0 commits into from
Closed

Torch Lcm Frontend #4972

wants to merge 0 commits into from

Conversation

nassimberrada
Copy link
Contributor

PR for issue #4937

@ivy-leaves ivy-leaves added the PyTorch Frontend Developing the PyTorch Frontend, checklist triggered by commenting add_frontend_checklist label Sep 27, 2022
@nassimberrada
Copy link
Contributor Author

Tests Passed

Ishticode
Ishticode suggested changes Sep 29, 2022
View reviewed changes
Copy link
Contributor

@Ishticode Ishticode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great effor Nassim. As all the backends have a supported version of lcm, we will wait for the Ivy api extension.

@nassimberrada
Copy link
Contributor Author

Status: Waiting for ivy.lcm

@Ishticode
Copy link
Contributor

Status: Waiting for ivy.lcm

You're welcome to implement it yourself.

@nassimberrada
Copy link
Contributor Author

I raised the issue for the ivy.lcm extension, just waiting for it to be up

@nassimberrada nassimberrada deleted the lcm_torch branch October 10, 2022 10:16
@nassimberrada nassimberrada restored the lcm_torch branch October 10, 2022 10:17
@nassimberrada nassimberrada deleted the lcm_torch branch October 10, 2022 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ishticode Ishticode Ishticode requested changes

Assignees

@Ishticode Ishticode

Labels
PyTorch Frontend Developing the PyTorch Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nassimberrada @Ishticode @ivy-leaves