Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add torch pairwise_distance #6996

Merged
merged 7 commits into from Nov 16, 2022
Merged

add torch pairwise_distance #6996

merged 7 commits into from Nov 16, 2022

Conversation

phonphrm
Copy link
Contributor

Add Distance functions to PyTorch Frontend #25

@ivy-leaves ivy-leaves added the PyTorch Frontend Developing the PyTorch Frontend, checklist triggered by commenting add_frontend_checklist label Nov 14, 2022
@phonphrm
Copy link
Contributor Author

#6995

@phonphrm
Copy link
Contributor Author

@DragosStoican I have recently fixed some floating point accuracy error. I have locally tested on my PC and all tests were passed! Thank you so much for your time, Have a good day.

@phonphrm
Copy link
Contributor Author

I'm looking forward for your review 🥺 @DragosStoican

@DragosStoican
Copy link
Contributor

Hi @jonaspptawat, I'm having a look today, sorry for the wait, and thanks for your contribution!

@phonphrm
Copy link
Contributor Author

It's okay. Thank you for your reply and take ur time to review my code. Have a good day sir😁

@DragosStoican
Copy link
Contributor

Hi @jonaspptawat the frontend tests should cover all the function arguments. Your test is missing the eps argument. Could you add that in and see if the test is still passing? 😄

@DragosStoican
Copy link
Contributor

Also🙂 , I will link this to the corresponding issue, but in future you should do this yourself by adding a comment ‘Close #Issue_number’, as explained here

@DragosStoican DragosStoican linked an issue Nov 16, 2022 that may be closed by this pull request
pairwise_distance #6995
Closed
@DragosStoican
Copy link
Contributor

Oh, it's not affecting the computation, I see it now 😅 My bad

@DragosStoican DragosStoican merged commit 4fc291a into Transpile-AI:master Nov 16, 2022
@phonphrm
Copy link
Contributor Author

Thank you so much @DragosStoican ! I will read through the link that you gave me.

KevinUnadkat pushed a commit to KevinUnadkat/ivy that referenced this pull request Dec 4, 2022
@phonphrm @KevinUnadkat
add torch pairwise_distance (Transpile-AI#6996)
f21187e 
* add pairwise_distance for torch frontends

* Update test_distance_functions.py

* Update distance_functions.py

* Update test_distance_functions.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@DragosStoican DragosStoican

Labels
PyTorch Frontend Developing the PyTorch Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pairwise_distance
3 participants
@phonphrm @DragosStoican @ivy-leaves