Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs/contributing: Document Co-authored-by usage #242

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

StefanJum
Copy link
Member

Since we started using Co-authored-by: tags in commit messages, this should be documented on the contributing/ page.

@StefanJum StefanJum added documentation Improvements or additions to documentation enhancement New feature or request labels May 8, 2023
Copy link
Contributor

@mariasfiraiala mariasfiraiala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Thanks a lot for this @StefanJum!

Reviewed-by: Maria Sfiraiala maria.sfiraiala@gmail.com

@RaduNichita
Copy link
Contributor

RaduNichita commented May 8, 2023

Sorry for bumping in, just wanted to say that there is a typo in the commit message and the title of the PR. It should be docs instead of dosc.

Since we started using `Co-authored-by:` tags in commit messages, this
should be documented on the `contributing/` page.

Signed-off-by: Stefan Jumarea <stefanjumarea02@gmail.com>
@StefanJum StefanJum force-pushed the StefanJum/add-coauthored-by-info branch from 13d971a to 8268f04 Compare May 8, 2023 11:41
@StefanJum StefanJum changed the title dosc/contributing: Document Co-authored-by usage docs/contributing: Document Co-authored-by usage May 8, 2023
@StefanJum
Copy link
Member Author

Fixed @RaduNichita, thanks 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add section regarding Co-authored-by/Signed-off-by differences to contributing/review-process.md
4 participants