Skip to content
This repository has been archived by the owner on Mar 22, 2023. It is now read-only.

Propagate the dir=ltr/rtl attribute to iframe.html also #24

Open
MXTcomunica opened this issue Nov 8, 2021 · 1 comment
Open

Propagate the dir=ltr/rtl attribute to iframe.html also #24

MXTcomunica opened this issue Nov 8, 2021 · 1 comment

Comments

@MXTcomunica
Copy link

The dir="ltr" (or "rtl") attribute is not preserved clicking on the "Open canvas in new tab" top right icon to check the story "alone" in a new browser tab.

It would be useful to keep the selected dir attribute value to the Storybook iframe.html as well.

Thank you very much for considering this.

@literalpie
Copy link
Collaborator

This is a very valid thing to ask for, especially now that we allow the direction to be set as a parameter (Allowing you to set the direction even if the addon panel is never loaded)

Unfortunately, I believe that the addon is built in a way that wouldn't support this without some refactoring. (For example, we could consider using decorators instead of the code we currently have in the manager).

I'm certainly open to making this change, but I probably won't personally work on it in the near term. If anyone wants to work on it, feel free to run ideas by me, or add reactions to this issue so we can gauge how many people would get value from this feature

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants