Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename colorProvider setting to nodeFillColor #67

Closed
pverscha opened this issue Apr 21, 2021 · 4 comments
Closed

Rename colorProvider setting to nodeFillColor #67

pverscha opened this issue Apr 21, 2021 · 4 comments

Comments

@pverscha
Copy link
Member

There are currently two different option settings for determining the color of a node: nodeFillColor and colorProvider. The colorProvider should be renamed to nodeFillColor and nodeFillColor should be removed in order to avoid confusing our users.

Note that we should also update the documentation and Observable notebook accordingly.

@bmesuere
Copy link
Member

Should we add an alias and mark the old name as deprecated as a first step? Because otherwise this will break for existing users.

@pverscha
Copy link
Member Author

Good point, I'll update it as you suggested :)

@pverscha
Copy link
Member Author

After some more investigating, I found out that all settings related to color behave identically to how they behaved in version 1 of the visualizations, except for one: nodeFillColor.

Setting nodeFillColor to (d) => "#00FF00" results to this in v1.0 of the treeview:
image

And has no effect in v2.0:
image

This is due to the fact that no fill is set for the nodes in v2.0, which we should fix. I propose that we do not rename the option and that I fix the nodeFillColor setting. All behaviour will then be identical to v1.0

@pverscha
Copy link
Member Author

Fixed in #68.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants