Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reducer in first level #18

Closed
fabienjuif opened this issue Jan 20, 2018 · 4 comments · Fixed by #19
Closed

reducer in first level #18

fabienjuif opened this issue Jan 20, 2018 · 4 comments · Fixed by #19
Assignees
Labels
bug Something isn't working

Comments

@fabienjuif
Copy link
Member

This doesn't work (reducer in first level):

    const store = createStore({
      config: { type: 'simpleObject' },
    })

    store.config.set('config me')
    expect({
      state: store.getState(),
      config: store.config.get(),
    }).toMatchSnapshot()
@fabienjuif fabienjuif added the bug Something isn't working label Jan 20, 2018
@fabienjuif fabienjuif self-assigned this Jan 20, 2018
@fabienjuif
Copy link
Member Author

hmm it seems to work on master

@fabienjuif
Copy link
Member Author

Ok this is selectors that doesn't works in first level: config: store.config.get(),

@fabienjuif
Copy link
Member Author

If I do:

      return factory({ name, path: path.length > 0 ? path : undefined, ...options })

instead of

      return factory({ name, path, ...options })

it works.

Maybe this more a k-redux-factory bug

@fabienjuif
Copy link
Member Author

Yeah this more about k-redux-factory, waiting for unirakun/k-redux-factory#84

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant