Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docEval and docEvalInline shouldn't permit abilities #2238

Closed
1 of 2 tasks
pchiusano opened this issue Jul 16, 2021 · 0 comments · Fixed by #2240
Closed
1 of 2 tasks

docEval and docEvalInline shouldn't permit abilities #2238

pchiusano opened this issue Jul 16, 2021 · 0 comments · Fixed by #2240
Assignees
@pchiusano
Labels
C3 Quite certain documentation E1 Lowest effort/time I1 Low impact R3 High reach

Comments

@pchiusano
Copy link
Member

pchiusano commented Jul 16, 2021 •
edited
Loading 

ex = {{ 

Inline evaluation: @eval{ Abort.abort }

}}

image

  • Update IOSource and update the pretty-printer to pretty-print both the old and new hash via the same syntax. This will normalize away usage of the old functions as docs get updated.
  • Update unisonweb/base with new implementation of these functions

That will take care of non-malicious usage. For preventing malicious usage we'll have to wait for #2237
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pchiusano pchiusano

Labels
C3 Quite certain documentation E1 Lowest effort/time I1 Low impact R3 High reach
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't allow docEval and docEvalInline to use other abilities unisonweb/unison
1 participant
@pchiusano