ucm and the LSP do not validate Int (and Nat) for range

[kylegoetz]

Put in a scratch file:

x : Int
x = +922337203685477580745235235252352

UCM will tell you

These new definitions are ok to `add`:
      x : Int

and the LSP in VS Code will also not complain.

However, the docs indicate that Int has a max value of 9223372036854775807. Clearly the x is larger than this. Also when I search for the max value in the Github repo, I do not find a single instance of this value in the parsing code.

Edit The same is true of Nat if you remove the + and redefine to x : Nat

[kylegoetz]

My guess is that it comes down to this code in Pattern.hs,

unison/unison-core/src/Unison/Pattern.hs

Line 27 in 2aa0a98

| Nat loc !Word64

data Pattern loc
  = Unbound loc
  | Var loc
  | Boolean loc !Bool
  | Int loc !Int64
  | Nat loc !Word64
 [snip]
  deriving (Ord, Generic, Functor, Foldable, Traversable)

Edit Or one of the other places in the codebase where Nat is defined as an alias for Word64 and Int for Int64.

[aryairani]

The parser/lexer could load these as a BigInt and check the range