Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GRIMRenderer broken #272

Closed
reinago opened this issue Mar 29, 2019 · 1 comment
Closed

GRIMRenderer broken #272

reinago opened this issue Mar 29, 2019 · 1 comment
Assignees

Comments

@reinago
Copy link
Member

reinago commented Mar 29, 2019

Indeed the GRIMRenderer can still be faster than NGSphere if bricking is done properly, I observed 2x FPS for laser.big, but in the current state it's broken since the referenced shader snippets were renamed and possibly changed around a little bit when all the sphere shaders were combined into one.

For reference, the ISC_Demo_IceT tag has a fully working GRIM renderer, just capture the shaders from there and check what's broken.

This helps getting rid of the warnings, but I think I still mislinked some snippet:

$ git diff core/Shaders/mipdepth6.btf
diff --git a/core/Shaders/mipdepth6.btf b/core/Shaders/mipdepth6.btf
index bb4662034..7df6dd1fe 100644
--- a/core/Shaders/mipdepth6.btf
+++ b/core/Shaders/mipdepth6.btf
@@ -11,12 +11,12 @@
 #define DEFERRED_SHADING
 ]]>
     </snippet>
-    <snippet name="simplesphere::vertex::attributes" />
-    <snippet name="simplesphere::vertex::MainParams" />
-    <snippet name="simplesphere::vertex::posTrans" />
-    <snippet name="simplesphere::vertex::clippingPlane" />
+    <snippet name="simplesphere::vertex::Attributes" />
+    <snippet name="simplesphere::vertex::MainStart" />
+    <snippet name="simplesphere::vertex::PosTrans" />
+    <snippet name="simplesphere::vertex::ClippingPlane" />
     <snippet name="simplesphere::vertex::SphereTouchPlane" />
-    <snippet name="simplesphere::vertex::Output" />
+    <snippet name="simplesphere::vertex::PosOutput" />
     <snippet type="string">
       <![CDATA[
 }]]>
@@ -323,8 +323,8 @@ void main(void) {
 varying float pointSize;
 ]]>
     </snippet>
-    <snippet name="simplesphere::fragment::body1" />
-    <snippet name="simplesphere::fragment::out-depth" />
+    <snippet name="simplesphere::fragment::MainStart" />
+    <snippet name="simplesphere::fragment::OutDepth" />
     <snippet type="string">
       <![CDATA[
   gl_FragData[0] = vec4(color.rgb, 1.0);
@braunms
Copy link
Contributor

braunms commented Apr 4, 2019

Will be fixed in pull request #278.

@braunms braunms closed this as completed Apr 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants