Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add and remove liquidity tests are not working correctly #1

Closed
shanefontaine opened this issue Jan 3, 2019 · 3 comments
Closed

Add and remove liquidity tests are not working correctly #1

shanefontaine opened this issue Jan 3, 2019 · 3 comments
Labels
bug Something isn't working

Comments

@shanefontaine
Copy link
Collaborator

The add and remove liquidity tests are failing when being sent to the main network. This does not happen when calling the functions directly.

An example of a bad transaction is here.
@shanefontaine shanefontaine added the bug Something isn't working label Jan 3, 2019
@shanefontaine
Copy link
Collaborator Author

The make_trade with recipient calls also intermittently fail.

Example

@shanefontaine
Copy link
Collaborator Author

shanefontaine commented Jan 4, 2019 •
edited

Seemingly _token_to_eth_swap_output and _token_to_eth_transfer_output are the only two failing and it only happens during testing when multiple transactions process simultaneously. Calling them normally works fine.

@shanefontaine
Copy link
Collaborator Author

Apparenlty the issues were fixed with these two commits.

I am not totally sure what did it. It looks like raising the amount sent help.

Following the rounding suggestion here seemed to help the add_liquidity function. Will reopen if issue persists.

@ToniKuipers ToniKuipers mentioned this issue May 5, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@shanefontaine